09:00:44 #startmeeting check-in_20161216 09:00:44 Meeting started Fri Dec 16 09:00:44 2016 UTC. The chair is brainfunked. Information about MeetBot at http://wiki.debian.org/MeetBot. 09:00:44 Useful Commands: #action #agreed #halp #info #idea #link #topic. 09:00:44 The meeting name has been set to 'check-in_20161216' 09:00:53 #topic brainfunked's updates 09:03:26 #info I spent yesterday finishing off reviews. Some yet remain, such as the import cluster and provisioning of the monitoring stack. However, I feel that these need to be addressed by an overarching spec about the node agent and namespaces shipped with it by default. This also plays into the provisioning feature as a whole. I need to spend a couple of days next week to get this sorted out. In the meanwhile, I'll add comments on the import 09:03:27 cluster spec so that the parts of the implementation that can be completed without being blocked by the new spec I'll add, can be implemented. I'll also be reviewing the UX designs and the UI related specs today. 09:03:34 #undo 09:03:34 Removing item from minutes: INFO by brainfunked at 09:03:26 : I spent yesterday finishing off reviews. Some yet remain, such as the import cluster and provisioning of the monitoring stack. However, I feel that these need to be addressed by an overarching spec about the node agent and namespaces shipped with it by default. This also plays into the provisioning feature as a whole. I need to spend a couple of days next week to get this sorted out. In the meanwhile, I'll add comments on the import 09:04:18 #info I spent yesterday finishing off the pending reviews from day before. 09:05:36 #action brainfunked: I have a realisation that the import cluster and monitoring provisioning spec are linked to the provisioning specs which we haven't picked up yet. I'll work on drawing up a spec that clarifies the namepsaces and flows carried by the node agent by default to satisfy all these specs. 09:06:20 kaverma, neha__, can we schedule a call after the check-in to review and update the UI specifications as necessary? 09:06:47 brainfunked, when can do our api integrations call then? 09:06:54 *we do 09:06:59 brainfunked, yes 09:08:58 #action brainfunked to help review and update the UI specifications post the check-in with kaverma and neha__ 09:09:06 #topic anmol's updates 09:09:14 Please view my check-in update @ https://paste.fedoraproject.org/507307/48187283/ 09:09:14 Summary: 09:09:14 1. Following up on comments on spec PRs mentioned above. 09:09:15 Today's Agenda: 09:09:15 1. Accomplish yesterday's agenda of having spec PRs merged. 09:09:15 2. Started on implementation(rework. Previous work @ https://github.com/Tendrl/alerting/pull/1) of https://github.com/Tendrl/specifications/pull/18 09:10:31 #info I've asked for the monitoring provisioning specification https://github.com/Tendrl/specifications/pull/20 till I complete the node agent spec I've mentioned above anmol 09:11:14 anmol, based on your leave schedule, I think you can work on that after you're back, while today and on Monday, you can work on the other specifications' implementation 09:11:26 brainfunked, yes ok 09:11:43 anmol, the priority needs to be to finish the API integration at this point, for alerting, so that kaverma and neha__ get a clear sense of how they'll be consuming the alerts 09:11:53 anmol, works for you? 09:12:15 brainfunked, ok 09:12:32 cool 09:12:59 brainfunked, but for that we probably need to close on 2 spec prs 09:13:18 brainfunked, the alert pluggability one and time series spec 09:13:25 #action anmol to prioritise the API integration https://github.com/Tendrl/specifications/issues/62 by working directly with noopq to finalise the spec today and start the implementation 09:13:36 ok 09:13:45 anmol, I was awaiting updates on the alert pluggability one after my review yesterday 09:14:00 if that's in, I can go check immediately after the check-in and approve it 09:14:04 brainfunked, I did it yesterday late night 09:14:21 brainfunked, I was on it but it took some time and you had left by then 09:14:36 anmol, alright, in which case, I think it should get approved immediately after this meeing and you can go ahead and start implementing that 09:14:51 brainfunked, I started on it already 09:15:06 brainfunked, not much its primitive at this stage although 09:15:13 that's good 09:15:15 keep at it :) 09:15:43 :) 09:15:48 #action brainfunked to validate the changes to the alerting pluggability spec from the review at https://github.com/Tendrl/specifications/pull/18 and approve accordingly 09:16:10 #action anmol also working on the implementation for the alerting pluggability spec https://github.com/Tendrl/specifications/pull/18 09:16:33 alright, thanks, please concentrate on these two specs in the next couple of days before your leave 09:16:43 sure 09:16:44 get the code pushed so reviews can be done in your absense 09:16:50 ok 09:16:58 and I'll ensure that the details for the provisioning spec are available by the time you come back 09:17:05 is noopq around yet? 09:17:14 #topic dahorak's updates 09:17:42 Same status as yesterday, I was working on unrelated tasks. 09:18:44 brainfunked, yes 09:19:02 #info dahorak has no updates "I was working on unrelated tasks." 09:19:06 #topic noopq's updates 09:19:28 noopq, based on our discussion late yesterday night, I've asked anmol to get on a call with you to sort out the API integration stuff on priority 09:20:07 brainfunked, we hada call earlier about what details were required from the UX designs 09:20:25 brainfunked, but, yes we need to have a call for the integration, we can do that today 09:20:39 noopq, please finish that on priority, immediately if possible 09:20:54 push the changes to the spec so we can review immediately too 09:21:42 noopq, do you have clarity about the requirements from the from the UX designs and from kaverma and neha__? 09:22:35 anmol, can you tell me the github issue for monitoring task 09:23:18 brainfunked, I am finishing the list/inventory UX first, cheking what is available and what needs to be provided to have all the details 09:23:19 neha__, ok looking... 09:23:55 brainfunked, we need to add some more attributes to the yaml, I am working on the spec for that. 09:23:57 noopq, I would suggest that we target today to get the details in, so that the API work can be targeted to enable the inventory, import cluster, monitoring and alerting features 09:24:04 noopq, awesome thanks 09:24:38 noopq, once the details are in, you can then figure out how to prioritise the API work, there are existing specs that are implemenation details rather than feature enablement and can be balanced with these 09:24:43 noopq, works? 09:24:52 brainfunked, agree. 09:24:56 ack 09:25:45 #accept noopq working on a specification for flow updates required to satisfy all the requirements for the list views/inventory feature 09:25:49 brainfunked, I will need you for the import cluster UX gap with the API, the UX needs lots of new details etc, see this https://redhat.invisionapp.com/share/R88EUSGJK 09:26:09 we can get on a call if its needed 09:26:27 #accept noopq working with anmol to detail out the API integration requirements for alerting and monitoring 09:26:40 neha__, https://github.com/Tendrl/performance_monitoring/issues/7, https://github.com/Tendrl/performance_monitoring/issues/8, https://github.com/Tendrl/performance_monitoring/issues/9, https://github.com/Tendrl/alerting/issues/10, https://github.com/Tendrl/alerting/issues/11, https://github.com/Tendrl/alerting/issues/12, https://github.com/Tendrl/alerting/issues/13 and https://github.com/Tendrl/alerting/issues/14 09:27:23 #action brainfunked and noopq to review the import cluster UX and spec out the new details required based on https://redhat.invisionapp.com/share/R88EUSGJK 09:27:33 noopq, ack 09:27:46 #topic fbalak's updates 09:27:54 Issue: https://github.com/Tendrl/usmqe-setup/tree/tendrl-setup-ceph - Creating ansible playbook for Installation of Tendrl with Ceph and testing it 09:27:55 Progress: Working on it 09:27:57 Status: Good 09:29:08 fbalak, this is also validating the API documentation, right? 09:29:25 brainfunked: yes 09:31:21 fbalak, did you review https://github.com/Tendrl/specifications/pull/18 ? 09:32:27 brainfunked: no, but I can look into it 09:32:46 #accept fbalak working on creating ansible playbooks to deploy tendrl with ceph and validating the API documentation in the process 09:33:09 fbalak, plesae check it on priority, it's just a read-through for the API related changes to ensure that they can be tested 09:33:23 brainfunked: ok 09:33:26 #action fbalak to review the pluggable alerts specification https://github.com/Tendrl/specifications/pull/18 09:33:35 #topic gowtham_'s updates 09:33:48 Adding disk details in hardware inventory 09:34:04 spec file: https://github.com/Tendrl/specifications/pull/21 09:34:04 code-PR: https://github.com/Tendrl/node_agent/pull/64 09:34:12 git-issue: https://github.com/Tendrl/node_agent/issues/78 09:34:18 Adding Network details in hardware inventory 09:34:19 git-issue: https://github.com/Tendrl/node_agent/issues/78 09:34:19 spc file: https://github.com/Tendrl/specifications/pull/19 09:34:19 code-PR: https://github.com/Tendrl/node_agent/pull/79 09:34:45 as per anup suggestion am i store disk details like 09:34:46 for free disk nodes/node_id/Free_Disk 09:34:46 for used disk nodes/node_id/Used_Disk 09:34:51 is that ok? 09:35:10 i have a problem with disk structure in etcd 09:35:46 gowtham_, have you commented on the spec and asked for your concern to be reviewed? 09:35:58 brainfunked, yes i commented 09:36:19 gowtham_, who needs to address it? 09:36:33 gowtham_, please post the link to your comment 09:36:40 brainfunked, i wall yours suggestion and rohan and nisanth 09:36:57 *want suggestion 09:37:00 ok 09:37:24 link please? 09:37:35 brainfunked, network details patch is ready, i am done all changes 09:37:41 status good 09:37:41 also, any progress on tagged logging https://github.com/Tendrl/specifications/issues/28 09:38:03 brainfunked, i am not seen yet i will see it 09:38:29 gowtham_, please give me the link to your comment which needs to be responded to by us 09:38:41 brainfunked, ok 1 sec 09:38:51 brainfunked, https://github.com/Tendrl/specifications/pull/21#pullrequestreview-13196512 09:40:37 thanks, please start working on tagged logging spec 09:40:43 brainfunked, sure 09:40:49 brainfunked, i will start now 09:40:56 #action brainfunked, k4n0 and nishanth to respond to gowtham_'s concerns on the disk inventory spec at https://github.com/Tendrl/specifications/pull/21#pullrequestreview-13196512 09:41:15 #action gowtham_ to start working on the tagged logging specification https://github.com/Tendrl/specifications/issues/28 09:42:25 #accept gowtham_ has sent updates to the disk and network inventory specifications https://github.com/Tendrl/specifications/issues/43 and https://github.com/Tendrl/specifications/issues/41 09:42:41 #topic kaverma's updates 09:42:45 Title: import cluster workflow using UI 09:42:47 neha seems to have logged off 09:42:54 and she's back 09:42:55 Spec-PR: https://github.com/Tendrl/specifications/pull/64 09:42:59 #undo 09:42:59 Removing item from minutes: 09:43:06 #topic kaverma and neha__'s updates 09:43:16 Title: import cluster workflow using UI 09:43:25 Spec-PR: https://github.com/Tendrl/specifications/pull/64 09:43:34 Spec-Issue: https://github.com/Tendrl/specifications/issues/56 09:43:42 Github-PR: https://github.com/Tendrl/tendrl_frontend/pull/60 (working with mocked data for now as api support is not there for 2 step import cluster) 09:43:52 Github-Issue: https://github.com/Tendrl/tendrl_frontend/issues/63 09:43:59 Progress: incorporated nishanth's comment on my import cluster specs. and now going to review neha patches related to list-view. and there is gap b/w import-cluster-UX and current api so scheduled the meeting for it. 09:44:06 Status: good . not blocked. 09:44:09 End 09:44:13 ok 09:44:18 neha__, you around? 09:44:45 #accept kaverma has updated the import cluster UI spec https://github.com/Tendrl/specifications/issues/56 09:44:52 Writing the specs for list views and list component. 09:44:52 Issue - https://github.com/Tendrl/tendrl_frontend/issues/66 09:44:52 Updating the spec for host list view - https://github.com/Tendrl/specifications/pull/77 09:44:52 Estimate - 09:44:53 List(table) component implementation - 3 days(exclunding ut) 09:44:53 Donut and trending chart component implementation - 2 days(excluding ut) 09:44:55 for each list view - 2 days for template, filtering and sorting(if server side implemented), monitoring, API integration. 09:44:58 1 day for unit testing 09:45:00 time to implement the mechanism to fetch continuous monitoring data depends on which option are we choosing - long polling, web sockets, server sent events? 09:45:05 I will update the specs too with it. 09:45:07 Need inputs - Are we using server side implementation for filtering and sorting? 09:45:09 Needs API response format to start with the implementation for list views. 09:45:11 Which concept are we using to fetch continuous monitoring data? 09:45:13 Need sample monitoring data for each view. 09:45:18 kaverma, https://github.com/Tendrl/tendrl_frontend/issues/63 needs to be part of the import cluster UI spec itself 09:45:27 kaverma, I'm marking it as invalid and closing it 09:45:42 kaverma, whatever was planned for this spec needs to be part of #56 itself 09:45:56 kaverma, hold on, my mistake 09:46:05 kaverma, this is valid, but link it to the spec 09:46:16 brainfunked, ok 09:46:33 kaverma, we need to be able to navigate to this issue from the issue #56 on the specs repo 09:46:55 brainfunked, sure . i will linked 09:47:55 on the server side filtering and sorting, I would assume at this stage that it's a negative from the API neha__ 09:48:17 neha__, if it doesn't perform as needed on the client side, we may need a middleware to take care of these things 09:48:27 neha__, but for now, I don't think the API will provide filtering and sorting 09:48:47 neha__, then again, let's hash out the details on exactly what needs to be filtered and sorted first, check the data structures and then take a call on this 09:49:17 neha__, have you added these concerns to the specification so that people reviewing can address them? 09:49:20 brainfunked, ok..will check 09:49:42 not yet, I am adding it 09:49:46 ok 09:50:26 #action kaverma to link the issues on the frontend repo to the appropriate specifications 09:50:36 #action neha__ to add concerns and estimates to the specifications 09:50:51 already added an action item for us to review the specs together, so moving on 09:50:58 #topic nishanth's updates 09:51:16 And I have scheduled the meeting from 3;30. I have invited you and kaverma. Do I need to invite anyone else? 09:51:33 #info brainfunked: I had notified nishanth yesterday that it will take some time to add review and updates to the import cluster flow. I've stated earlier what the reason for that is. 09:51:42 ssue: https://github.com/Tendrl/specifications/issues/54 09:51:43 Spec-PR: https://github.com/Tendrl/specifications/pull/60 09:51:43 Progress and status: Need Review !!! 09:51:54 - Reviews 09:51:55 - https://github.com/Tendrl/specifications/pull/64 09:51:55 - https://github.com/Tendrl/specifications/pull/63 09:51:55 - https://github.com/Tendrl/specifications/pull/77 09:51:55 - https://github.com/Tendrl/specifications/pull/73 09:51:55 neha__, the three of us should be ok for now, post the meeting we'll see if we need another with noopq|away 09:52:16 brainfunked, ok 09:52:50 planning to spend time on reviews today, until the import spec is reviewed 09:52:57 nishanth, in light of the delay in the review on the import cluster spec, could you take up something else or assist someone else over the next couple of days? 09:54:01 Ok, planning spend some time on https://github.com/Tendrl/specifications/pull/73 09:54:28 ack, thanks 09:54:31 Also I am not seeing any reviews done by the QE folks 09:54:46 nishanth, which specs do you need them to review? 09:55:18 Monitoring, import, ideally they should be reviewing all the specs and provide inputs 09:55:20 nishanth, brainfunked i am working on https://github.com/Tendrl/specifications/pull/73 09:56:08 t1m1, ack, but it's a high priority one, so nishanth will also be helping with it just so speed up the process :) 09:56:21 ok 09:56:37 mkudlej, comments on nishanth's concern regarding the lack of reviews from the testing team on the specifications? 09:57:44 nishanth, could please provide the links to the spec issues that need to be reviewed? 09:58:59 yes, I can , I will compile a list provide. Meantime we can move on with checkin 09:59:25 nishanth, ok 10:00:16 #accept nishanth has posted the import cluster spec, which is now pending on brainfunked https://github.com/Tendrl/specifications/issues/54 10:00:32 #action nishanth to continue reviewing specs 10:01:15 #action nishanth to collaborate with t1m1 on the service detection modules spec https://github.com/Tendrl/specifications/issues/46 10:01:37 #action nishanth to bring the list of pending reviews to mkudlej 10:02:01 #info fbalak has already agreed to review one of the specs nishanth needs to get reviewed from the testing team 10:02:09 #topic ndarshan's updates 10:02:12 mkudlej, are you around? 10:02:33 #info the calendar shows mbukatov to be on PTO 10:03:41 -----Github specification issue title and link----- 10:03:41 Specification for adding tendrl-common utils (https://github.com/Tendrl/specifications/issues/72) 10:03:41 -----Issues----- 10:03:41 https://github.com/Tendrl/common/issues/80 10:03:41 -----Summary of the update across the whole specification---- 10:03:42 Sent PR(https://github.com/Tendrl/common/pull/79) for implementation of spec mentioned above, Have addressed one set of comments. Request others to review. 10:03:45 -----Blockers----- 10:03:47 Want to get the above merged before EOD. will be on vacation from monday. 10:03:49 -----My Reviews----- 10:03:49 kaverma, btw, can you guys assign issues on the frontend repository? 10:03:51 https://github.com/Tendrl/node_agent/pull/84 10:04:42 ndarshan, who needs to review? 10:04:45 brainfunked: mkudlej will write you in about a half an hour 10:05:14 brainfunked: nishanth, brainfunked and rohan 10:05:24 fbalak, ack 10:05:26 brainfunked, ack 10:05:48 fbalak, regarding the reviews? 10:06:02 ndarshan, ok 10:06:21 #accept ndarshan has updated the common utils implementation https://github.com/Tendrl/common/pull/79 10:06:35 (there's a note from ndarshan on the list about brick provisioning via gdeploy. this is exploring how to get that done. not sure if this already has been discussed) 10:07:07 #action brainfunked, nishanth and k4n0 to review https://github.com/Tendrl/common/pull/79. It needs to be merged today. 10:07:29 sankarshan, I've seen the email, I'll go through it again as work on the gdeploy integration spec next week 10:07:39 #topic Shu6h3ndu's updates 10:07:49 Issue: https://github.com/Tendrl/specifications/issues/30 (Accomodate gluster get-state cli changes post gluster 3.9) 10:07:50 Spec: https://github.com/Tendrl/specifications/pull/6 (Added specification for refactoring gluster get-state output) 10:07:50 Progress: code change PR under review 10:07:51 Status: Comments incoporated. Need to be reviewed and merged 10:07:53 Issue: https://github.com/Tendrl/specifications/issues/31 (Refactor Tendrl framework sub modules) 10:07:55 Spec: https://github.com/Tendrl/specifications/pull/7 (Added specifications for refactoring tendrl code) 10:07:58 Progress: code change PR under review. Started on gluster_integration changes today 10:08:00 Status: NOT BLOCKED 10:08:02 Issue: https://github.com/Tendrl/gluster_integration/issues/74 (Implement the pre and post runs for volume operations) 10:08:07 Spec: NA (OLD ONE) 10:08:09 Progress: Review in progress 10:08:11 Status: NOT BLOCKED 10:08:13 Issue: https://github.com/Tendrl/gluster_integration/issues/73 (Delete the volume entry from etcd as well while volume delete) 10:08:16 Spec: NA (OLD ONE) 10:08:18 Progress: Review in progress 10:08:24 Status: NOT BLOCKED 10:08:26 Finished spec reviews today 10:08:28 For https://github.com/Tendrl/specifications/issues/31 I created individual issues for code coverage 10:08:30 Summary, started working on gluster module for refactoring today 10:08:32 ran into one issue in node_agent and with the help of darshan have solution for the same. will update the PR soon 10:08:56 Bit skeptic about Monday at the moment, but lets see 10:09:56 Shu6h3ndu, Tuesday then? :) 10:10:31 brainfunked, test case failures also are there. so with comfort I would say wednesday, if reviews are on top 10:10:48 Shu6h3ndu, btw, all except the gluster integration issue seem to be linked to the spec issue 10:11:09 brainfunked, yes. 10:11:10 Shu6h3ndu, unless you meant the get-state issue being the one worked on 10:11:30 brainfunked, get-state can actually be merged. no major comments at the moment 10:11:50 brainfunked, refactor might take bit more 10:11:57 Shu6h3ndu, my impression was that the get-state changes are different from the refactoring, that correct? 10:12:10 brainfunked, thats correct. they are two different PRs 10:12:28 brainfunked, both spec PR are merged and code changes under review 10:12:31 ok, then please link the refactoring one on the gluster integration to the refactoring spec issue 10:13:00 brainfunked, its linked already 10:13:53 can't see it at https://github.com/Tendrl/specifications/issues/31 10:13:56 everyone else shows up 10:14:15 #accept Shu6h3ndu's refactoring and gluster get-state specs have been merged 10:14:25 #action Shu6h3ndu working on gluter integration refactoring 10:14:41 brainfunked, cool. thanks 10:15:19 #info refactoring may not be completed by Monday due to test case failures. New estimate is Wednesday. 10:15:49 Shu6h3ndu, please finish this as fast as possible, there are some priority items we could really use your hands on :) 10:16:14 brainfunked, trying my best man :)) 10:16:53 Shu6h3ndu, I know :) 10:16:58 #topic t1m1's updates 10:17:00 brainfunked, as part of re-factor we are doing some cleanup as well 10:17:09 Updated review comment: https://github.com/Tendrl/documentation/pull/69 10:17:09 Updated fix patch: ready for merge→ https://github.com/Tendrl/node_agent/pull/100 10:17:09 (issue: https://github.com/Tendrl/node_agent/issues/97) 10:17:09 Sent patch for issue: https://github.com/Tendrl/node_agent/issues/89 10:17:47 working on https://github.com/Tendrl/specifications/issues/46 10:18:44 ok thanks 10:18:58 no prob; 10:19:23 #accept t1m1 has sent patches for mbukatov's issues https://github.com/Tendrl/node_agent/issues/89 and https://github.com/Tendrl/node_agent/issues/97 10:19:52 thanks everyone for the updates 10:20:11 #info mkudlej to contact brainfunked offline as mentioned by fbalak 10:20:16 #endmeeting